Update hello-world exercise and add two-fer exercise #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuxagon
suggested changes
Oct 29, 2018
There was a problem hiding this comment.
Sorry for not responding quicker. Thanks for the contribution, @benreyn! I love seeing new exercises get implemented. There are a few things that need to happen before we can get this merged.
- Please read this guide to get some more details about some missing pieces, like a
config.jsonentry. - You'll need to run the
configlettool to get the correct README and to lint the project
If you have questions, let me know!
benreyn
force-pushed
the
br-hello-two-fer
branch
from
3039678
to
6365cc1
Compare
tuxagon
suggested changes
Oct 31, 2018
tuxagon
approved these changes
Oct 31, 2018
|
@benreyn Thanks for the contribution! I'm going to go ahead and merge. It looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A decision was made upstream to simplify the hello-world exercise and implement a new exercise to take its place. This PR brings the elm track in line with these new changes.